Summary

• Renames the Formatter interface to Dialect for better semantic clarity
• Refactors all AST node Format methods to accept dialect as a parameter instead of storing it in TrackedBuffer
• Simplifies TrackedBuffer to be a pure buffer utility without dialect dependency

Key Changes

Interface Rename:

• format.Formatter → format.Dialect

Format Method Signature:

• Before: Format(buf *TrackedBuffer)
• After: Format(buf *TrackedBuffer, d format.Dialect)

TrackedBuffer Simplification:

• Removed formatter field - TrackedBuffer is now just a strings.Builder wrapper
• NewTrackedBuffer() no longer takes a dialect parameter

Method Call Updates:

• buf.astFormat(x) → buf.astFormat(x, d)
• buf.join(x, sep) → buf.join(x, d, sep)
• Dialect methods called directly: d.QuoteIdent(), d.TypeName(), d.Param(), d.Cast(), d.NamedParam()

Rationale

The name "Dialect" better describes what this interface represents - SQL dialect-specific formatting behavior. Making the dialect an explicit parameter to Format methods:

1. Makes the dependency explicit and traceable
2. Simplifies TrackedBuffer to be a pure utility class
3. Aligns with common patterns for dialect-aware SQL formatting

Test plan

• All TestFormat tests pass
• All TestReplay tests pass
• All go test ./... tests pass
• No regressions in PostgreSQL, MySQL, or SQLite formatting

🤖 Generated with Claude Code